make firebase-admin an optional dependency #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #707 +/- ##
==========================================
+ Coverage 70.28% 70.33% +0.05%
==========================================
Files 26 26
Lines 1097 1099 +2
Branches 249 249
==========================================
+ Hits 771 773 +2
Misses 288 288
Partials 38 38 ☔ View full report in Codecov by Sentry. |
50-Course
approved these changes
Feb 27, 2024
Comment on lines
-3
to
-6
| from firebase_admin import messaging | ||
|
|
||
| from .fields import HexIntegerField | ||
| from .gcm import dict_to_fcm_message |
50-Course
pushed a commit
that referenced
this pull request
Oct 3, 2024
Co-authored-by: Tim Jahn <tim@smartfactory.ch>
50-Course
pushed a commit
that referenced
this pull request
Oct 6, 2024
Co-authored-by: Tim Jahn <tim@smartfactory.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentation fix #703
mandatory dependency fix #702 (comment)